fix: skip rollback job for inline-run deploys#126
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the promote-workflow generator,
writeRollbackJobslooped over every deploy and unconditionally emitteduses: <normalized workflow path>. For an inline-run deploy (declared withrun:+shell:instead ofworkflow:), the workflow path is empty, so the generator wrote an emptyuses:value followed by awith:/secrets:block. That is invalid GitHub Actions YAML and actionlint flags it:string should not be empty [syntax-check].A rollback job is, by contract, a reusable-workflow call that reverts a deploy. An inline-run deploy has no reusable workflow to call, so it cannot have a rollback job.
Fix
Skip emitting a rollback job for any deploy whose workflow is empty (
Run != ""), mirroring how the deploy jobs themselves already branch on inline-run vs reusable-workflow. Applied to both local and external deploy rollback loops. The deploy-jobneeds:lists referencedeploy-<name>jobs (still present), notrollback-<name>, so no other job ends up depending on a now-absent rollback job.Verification
internal/generate/promote_test.go: a 3-env config with an inline-run deploy generates a promote workflow with no emptyuses:line, norollback-<name>:job, thedeploy-<name>:job still present, and structurally valid YAML. A mixed case keeps the rollback job for the reusable-workflow deploy.e2e/scenarios/13-inline-run-deploy-no-rollback.yamlasserting the generated promote.yaml shape.go build ./... && go test ./... && golangci-lint run ./...all pass (1177 tests). e2e module builds and vets clean.string should not be emptyerror at the previously-emptyuses:line is gone.